Allow revealing using a static receiver #5760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Sep 10, 2024
| resolver.ResolveNameSegment((NameSegment)effectiveExpr, true, null, resolutionContext, true); | ||
| } else { | ||
| resolver.ResolveDotSuffix((ExprDotName)effectiveExpr, true, null, resolutionContext, true); | ||
| resolver.ResolveDotSuffix((ExprDotName)effectiveExpr, true, true, null, resolutionContext, true); |
There was a problem hiding this comment.
These boolean flags are hard to review on GitHub, Non blocking for this one, but I would encourage in the future that we switch to enums when it's not obvious what a boolean is about. For example, StaticReferenceToInstance.Allowed.
There was a problem hiding this comment.
I'm a bit conflicted on this. There's also a third option of adding the argument name, so it would say allowStaticReferenceToInstance: true. Possibly you could configure a linter to always require the argument name for booleans.
Co-authored-by: Mikaël Mayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow revealing using a static receiver
How has this been tested?
Added the test
revealQualifiedId.dfyBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.